Convert some ABI tests to use extern "rust-invalid"
#142992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
This comment has been minimized.
This comment has been minimized.
|
gamer |
|
of course! |
workingjubilee
force-pushed
the
dont-validate-naughty-abis
branch
from
3b76349 to
253aeec
Compare
workingjubilee
commented
Jun 25, 2025
| @@ -1,5 +1,6 @@ | |||
| // FIXME(workingjubilee): add revisions and generalize to other platform-specific varargs ABIs, | |||
| // preferably after the only-arch directive is enhanced with an "or pattern" syntax | |||
| // NOTE: This deliberately tests an ABI that supports varargs, so no `extern "rust-invalid"` | |||
There was a problem hiding this comment.
An alternative would be to, in fact, say "yes, extern "rust-invalid" can support varargs", but that seems silly.
This comment has been minimized.
This comment has been minimized.
|
huh. |
workingjubilee
force-pushed
the
dont-validate-naughty-abis
branch
from
745849e to
accc2f9
Compare
The cross-build megatest gets extremely conflict-prone, so start cutting it into smaller pieces.
workingjubilee
force-pushed
the
dont-validate-naughty-abis
branch
from
accc2f9 to
f356217
Compare
workingjubilee
force-pushed
the
dont-validate-naughty-abis
branch
from
f356217 to
c24914e
Compare
workingjubilee
changed the title
extern "rust-invalid"extern "rust-invalid"
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
the
S-waiting-on-review
|
These commits modify compiler targets. The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
|
ehehehe. r? @jieyouxu since you asked for doc placement somewhere~ |
|
|
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 25, 2025
…ty-abis, r=jieyouxu Convert some ABI tests to use `extern "rust-invalid"`
bors
added a commit
that referenced
this pull request
Jun 25, 2025
Rollup of 7 pull requests Successful merges: - #142146 (Withdraw the claim `extern "C-cmse-nonsecure-*"` always matches `extern "C"`) - #142200 (`tests/ui`: A New Order [8/N]) - #142724 (Add runtime check to avoid overwrite arg in `Diag`) - #142809 (Add PrintTAFn flag for targeted type analysis printing) - #142976 (Check CoerceUnsized impl validity before coercing) - #142992 (Convert some ABI tests to use `extern "rust-invalid"`) - #143000 (Make `Sub`, `Mul`, `Div` and `Rem` `const_traits`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 26, 2025
Rollup merge of #142992 - workingjubilee:dont-validate-naughty-abis, r=jieyouxu Convert some ABI tests to use `extern "rust-invalid"`
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jun 26, 2025
Rollup of 7 pull requests Successful merges: - rust-lang/rust#142146 (Withdraw the claim `extern "C-cmse-nonsecure-*"` always matches `extern "C"`) - rust-lang/rust#142200 (`tests/ui`: A New Order [8/N]) - rust-lang/rust#142724 (Add runtime check to avoid overwrite arg in `Diag`) - rust-lang/rust#142809 (Add PrintTAFn flag for targeted type analysis printing) - rust-lang/rust#142976 (Check CoerceUnsized impl validity before coercing) - rust-lang/rust#142992 (Convert some ABI tests to use `extern "rust-invalid"`) - rust-lang/rust#143000 (Make `Sub`, `Mul`, `Div` and `Rem` `const_traits`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.